Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Contribute to GitLab
Sign in / Register
Toggle navigation
J
jadx
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
open-source
jadx
Commits
87c12314
Commit
87c12314
authored
Dec 05, 2018
by
Skylot
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix: show type inference errors as method comments
parent
d553157b
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
9 additions
and
4 deletions
+9
-4
TypeInferenceVisitor.java
...core/dex/visitors/typeinference/TypeInferenceVisitor.java
+9
-4
No files found.
jadx-core/src/main/java/jadx/core/dex/visitors/typeinference/TypeInferenceVisitor.java
View file @
87c12314
...
...
@@ -55,9 +55,13 @@ public final class TypeInferenceVisitor extends AbstractVisitor {
// try all possible types if var type is still unknown
mth
.
getSVars
().
forEach
(
var
->
{
ArgType
type
=
var
.
getTypeInfo
().
getType
();
TypeInfo
typeInfo
=
var
.
getTypeInfo
();
ArgType
type
=
typeInfo
.
getType
();
if
(
type
!=
null
&&
!
type
.
isTypeKnown
())
{
tryAllTypes
(
var
,
type
);
boolean
changed
=
tryAllTypes
(
var
,
type
);
if
(!
changed
)
{
mth
.
addComment
(
"JADX WARNING: type inference failed for: "
+
var
+
", bounds: "
+
typeInfo
.
getBounds
());
}
}
});
}
...
...
@@ -153,14 +157,15 @@ public final class TypeInferenceVisitor extends AbstractVisitor {
return
new
TypeBoundConst
(
BoundEnum
.
USE
,
regArg
.
getInitType
());
}
private
void
tryAllTypes
(
SSAVar
var
,
ArgType
type
)
{
private
boolean
tryAllTypes
(
SSAVar
var
,
ArgType
type
)
{
List
<
ArgType
>
types
=
makePossibleTypesList
(
type
);
for
(
ArgType
candidateType
:
types
)
{
TypeUpdateResult
result
=
typeUpdate
.
apply
(
var
,
candidateType
);
if
(
result
==
TypeUpdateResult
.
CHANGED
)
{
break
;
return
true
;
}
}
return
false
;
}
private
List
<
ArgType
>
makePossibleTypesList
(
ArgType
type
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment