Commit eafe080c authored by 13.beta2's avatar 13.beta2

core: omit redundant brackets in case blocks

parent 4f61ddd4
...@@ -146,7 +146,7 @@ public class InsnGen { ...@@ -146,7 +146,7 @@ public class InsnGen {
private String sfield(FieldInfo field) { private String sfield(FieldInfo field) {
String thisClass = mth.getParentClass().getFullName(); String thisClass = mth.getParentClass().getFullName();
if (field.getDeclClass().getFullName().equals(thisClass)) { if (thisClass.startsWith(field.getDeclClass().getFullName())) {
return field.getName(); return field.getName();
} else { } else {
return useClass(field.getDeclClass()) + '.' + field.getName(); return useClass(field.getDeclClass()) + '.' + field.getName();
......
...@@ -234,7 +234,6 @@ public class RegionGen extends InsnGen { ...@@ -234,7 +234,6 @@ public class RegionGen extends InsnGen {
SwitchNode insn = (SwitchNode) sw.getHeader().getInstructions().get(0); SwitchNode insn = (SwitchNode) sw.getHeader().getInstructions().get(0);
InsnArg arg = insn.getArg(0); InsnArg arg = insn.getArg(0);
code.startLine("switch(").add(arg(arg)).add(") {"); code.startLine("switch(").add(arg(arg)).add(") {");
code.incIndent();
int size = sw.getKeys().size(); int size = sw.getKeys().size();
for (int i = 0; i < size; i++) { for (int i = 0; i < size; i++) {
...@@ -256,13 +255,12 @@ public class RegionGen extends InsnGen { ...@@ -256,13 +255,12 @@ public class RegionGen extends InsnGen {
code.startLine("default:"); code.startLine("default:");
makeCaseBlock(sw.getDefaultCase(), code); makeCaseBlock(sw.getDefaultCase(), code);
} }
code.decIndent();
code.startLine('}'); code.startLine('}');
return code; return code;
} }
private void makeCaseBlock(IContainer c, CodeWriter code) throws CodegenException { private void makeCaseBlock(IContainer c, CodeWriter code) throws CodegenException {
code.add(" {");
if (RegionUtils.notEmpty(c)) { if (RegionUtils.notEmpty(c)) {
makeRegionIndent(code, c); makeRegionIndent(code, c);
if (RegionUtils.hasExitEdge(c)) { if (RegionUtils.hasExitEdge(c)) {
...@@ -271,7 +269,6 @@ public class RegionGen extends InsnGen { ...@@ -271,7 +269,6 @@ public class RegionGen extends InsnGen {
} else { } else {
code.startLine(1, "break;"); code.startLine(1, "break;");
} }
code.startLine('}');
} }
private void makeTryCatch(IContainer region, TryCatchBlock tryCatchBlock, CodeWriter code) private void makeTryCatch(IContainer region, TryCatchBlock tryCatchBlock, CodeWriter code)
...@@ -312,12 +309,13 @@ public class RegionGen extends InsnGen { ...@@ -312,12 +309,13 @@ public class RegionGen extends InsnGen {
} }
} }
// FIXME: !!code from InsnGen.sfield
private String sfield(FieldInfo field) { private String sfield(FieldInfo field) {
String thisClass = mth.getParentClass().getFullName(); String thisClass = mth.getParentClass().getFullName();
if (field.getDeclClass().getFullName().equals(thisClass)) { if (thisClass.startsWith(field.getDeclClass().getFullName())) {
return field.getName(); return field.getName();
} else { } else {
return useClass(field.getDeclClass()) + '.' + field.getName(); return useClass(field.getDeclClass()) + '.' + field.getName();
} }
} }
} }
\ No newline at end of file
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment